Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selenium grid support #45

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Selenium grid support #45

wants to merge 5 commits into from

Conversation

kahunacohen
Copy link

@s4int
See also #42.

I made some changes to the order and wording of options. @hellmanj , @frishberg last thing bothering me is two options for browser version, one for sauce and one for grid. I guess the option should be browser_version, not sauce_browserversion. That's an API-breaking change though isn't it? Or should I not be concerned, other than having to make some changes in the source code?

@s4int
Copy link

s4int commented Jun 10, 2015

I was thinking about about this naming convention and I don't feel comfortable with separate options prefixed with sauce_ or grid_ which are then copied to one desired_capabilities object.

I would prefer one desired_capabilities object which is used by sauce labs and selenium grid – common selenium configuration(this will also solve #37 and allow proxy support for selenium grid).

I can prepare such change in separate PR, which will be back compatible with current solution. Old parameters will be shown in log as deprecated and can be removed in the future.

@kahunacohen
Copy link
Author

That would be great. Do you need permissions to be a contributor to this repo? That may be easier than forking. Thanks for your input!

@kahunacohen
Copy link
Author

Wait, I'm not sure how this works, as this repo is technically NCBI's. Let me ask.

@kahunacohen
Copy link
Author

Alas, it's a bit of a pain to make you a direct contributer to repos in NCBI. So go ahead and do it in a fork and we will merge.

@kahunacohen
Copy link
Author

@s4int, @frishberg @hellmanj Hi where are we with this? As I remember and from reviewing the comments @s4int was going to rename the options etc. Though you don't have access to this branch directly and we don't have the ability to add you as a contributor to the NCBI project.
I guess you can work on it in your forked branch and we can merge to this one when you're done. Are you still interested in this PR?

@s4int
Copy link

s4int commented Jul 1, 2015

Hi, I'm steel interested.
I wanted to pass configuration as object but it appears that for now there is no way to do it nicely in robot framework.

Now I'm preparing PR with renamed variables

@randomsync
Copy link

@kahunacohen @s4int any updates on this? We also use an internal Selenium Grid and would like this feature. Thanks.

@kahunacohen
Copy link
Author

The truth is we are most likely putting this project up for adoption. Robot didn't work out so well for our organization. I will make an announcement and edit the reader. You are of course free to fork it.

Sent from my iPhone

On Aug 31, 2015, at 4:22 PM, Gaurav Gupta [email protected] wrote:

@kahunacohen @s4int any updates on this? We also use an internal Selenium Grid and would like this feature. Thanks.


Reply to this email directly or view it on GitHub.

@zlorb
Copy link

zlorb commented Sep 1, 2015

Can you please share more details as to why Robot framework did not work for your organization, and what alternate route you're picking?

Thanks in advance.

On Aug 31, 2015, at 6:15 PM, Aaron Cohen [email protected] wrote:

The truth is we are most likely putting this project up for adoption. Robot didn't work out so well for our organization. I will make an announcement and edit the reader. You are of course free to fork it.

Sent from my iPhone

On Aug 31, 2015, at 4:22 PM, Gaurav Gupta [email protected] wrote:

@kahunacohen @s4int any updates on this? We also use an internal Selenium Grid and would like this feature. Thanks.


Reply to this email directly or view it on GitHub.


Reply to this email directly or view it on GitHub.

@kahunacohen
Copy link
Author

Slow python 3 support in Robot Framework, developers prefer writing tests
in Python.

On Tue, Sep 1, 2015 at 11:23 AM, Zohar Lorberbaum [email protected]
wrote:

Can you please share more details as to why Robot framework did not work
for your organization, and what alternate route you're picking?

Thanks in advance.

On Aug 31, 2015, at 6:15 PM, Aaron Cohen [email protected]
wrote:

The truth is we are most likely putting this project up for adoption.
Robot didn't work out so well for our organization. I will make an
announcement and edit the reader. You are of course free to fork it.

Sent from my iPhone

On Aug 31, 2015, at 4:22 PM, Gaurav Gupta [email protected]
wrote:

@kahunacohen @s4int any updates on this? We also use an internal
Selenium Grid and would like this feature. Thanks.


Reply to this email directly or view it on GitHub.


Reply to this email directly or view it on GitHub.


Reply to this email directly or view it on GitHub
#45 (comment)
.

@conversica-aaronpa
Copy link

Really a shame this didn't get merged in, trying to run it but having trouble (newb here).

@dpsfrishberg
Copy link
Contributor

@kahunacohen, we can close this right? Since #42 takes care of it? @conversica-aaronpa, did you ever figure out how to use selenium-grid with this?

@conversica-aaronpa
Copy link

Yes, have been able to work with local selenium grid (docker hosted too, very nice) in place of Sauce Labs via fork: https://github.com/conversica-aaronpa/robotframework-pageobjects
I hacked code to allow me to provide remote_url parameter only, no sauce creds. Should I have already been able to do that without code changes? Couldn't get it to work as expected, so made some changes in a fork...

@dpsfrishberg
Copy link
Contributor

I actually was thinking #42 took care of it, but I had misread. I'm finally looking over and merging pull requests now, and see if I can resolve conflicts and merge this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants