Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed possible FPs for some GCP instances checks when 'true' is capitalized #1658

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

halfluke
Copy link

@halfluke halfluke commented Jul 18, 2024

Description

Make sure the PR is against the develop branch (see Contributing).

Make sure to set the corresponding milestone in the PR.
Sorry, I am not sure what this is...

During a GCP assessment, I noticed that SS was reporting some false positives for "block project-wide ssh keys".
I identified the problem in the fact that in the GCP project, some values were reported in capital "TRUE", while SS only checks for "true". Code fixed to handle both cases, also for "OS login enabled" and "serial port enabled", just in case.

Fixes # (issue)
I don't think there is an open issue for this.

Type of change

Select the relevant option(s):

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (optional)
  • New and existing unit tests pass locally with my changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant