change ms-based attribute to match depends on in assay. #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dependson item in the Mass Spec assay type did not match the attribute assigned to it. 'MS Based' was changed to "MS-based" to resolve mismatch.
|
Oh great spot @PozhidayevaDarya! Would you create and link and issue for this so we can track on the project board. Thank you! Assuming tests complete I will merge tomorrow morning and redeploy to staging |
|
Sure will do and all credit definitely to @clarisse-lau |
9 tasks
|
Merged. Have triggered redeployment to staging which should complete in 20 mins or so. https://github.com/ncihtan/HTAN-data-curator/actions/runs/5259257034 |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dependson item in the Mass Spec assay type did not match the attribute assigned to it.
'MS Based' was changed to "MS-based" to resolve mismatch.