Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add other wet suborders and SMR described only at subgroup level.
Suborders of Histosols other than "Folists" (Fibr-, Hem-, Sapr-) imply at least "aquic" moisture regime. These have been added. "wass" formative element used in suborders of Histosols and Entisols are now handled as the only current route into "peraquic" moisture regime.
For taxa that have no information about soil moisture regime at order to great group level it is valid to use the subgroup-level information, if present, to assign SMR.
extractSMR()
. In the cases where there isn't a higher-level connotation the subgroup does imply the SMR.For the future: dealing with parsing soil moisture subclasses via an additional option would be a great new feature, but they have more complex rules depending on the order/suborder they occur in. e.g. Aridic Mollisols have the subclass in the suborder. Currently
extractSMR()
is not aware of these types of relationships within taxon names and would need a more detailed set of rules or lookup table to handle these cases.