Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extractSMR updates #48

Merged
merged 2 commits into from
Oct 1, 2024
Merged

extractSMR updates #48

merged 2 commits into from
Oct 1, 2024

Conversation

brownag
Copy link
Member

@brownag brownag commented Oct 1, 2024

Add other wet suborders and SMR described only at subgroup level.

  1. Suborders of Histosols other than "Folists" (Fibr-, Hem-, Sapr-) imply at least "aquic" moisture regime. These have been added. "wass" formative element used in suborders of Histosols and Entisols are now handled as the only current route into "peraquic" moisture regime.

  2. For taxa that have no information about soil moisture regime at order to great group level it is valid to use the subgroup-level information, if present, to assign SMR.

    • Commonly subgroup level moisture formative elements are referring to a moisture subclass or are re-stating the class of the parent taxa.
    • If there is a higher-level connotation available (i.e. great group to order level) the highest level is always returned by extractSMR(). In the cases where there isn't a higher-level connotation the subgroup does imply the SMR.
library(SoilTaxonomy)

extractSMR('ustic haplargids')
#> ustic haplargids 
#>  aridic (torric) 
#> 7 Levels: aridic (torric) < ustic < xeric < udic < perudic < ... < peraquic
extractSMR('ustic haplocryolls')
#> ustic haplocryolls 
#>              ustic 
#> 7 Levels: aridic (torric) < ustic < xeric < udic < perudic < ... < peraquic

For the future: dealing with parsing soil moisture subclasses via an additional option would be a great new feature, but they have more complex rules depending on the order/suborder they occur in. e.g. Aridic Mollisols have the subclass in the suborder. Currently extractSMR() is not aware of these types of relationships within taxon names and would need a more detailed set of rules or lookup table to handle these cases.

 - add support for SMR described only at subgroup level
 - add aquic ("sapr", "hem", "fibr") and peraquic ("wass") suborders
@brownag brownag marked this pull request as ready for review October 1, 2024 22:21
@brownag
Copy link
Member Author

brownag commented Oct 1, 2024

New issue #49 to further handle subclasses. The approach here for partial matching can lead to some ambiguity if not filtering to just the highest level formative element related to moisture regime.

@brownag brownag merged commit 9b91ad2 into master Oct 1, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant