consolidation of depth axis arguments / style in plotSPC #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Quick comparison of "compact" vs. "traditional" axis styles. |
|
Need to account for NA horizon depths, currently failing all tests at |
|
@brownag I'm going to have to merge this soon. Happy to accept feedback on these topics when you return. |
|
New comparison, this time with "tape" style. Still generalizing position, always a problem with base graphics. |
brownag
approved these changes
Aug 11, 2023
Co-authored-by: Andrew Gene Brown <[email protected]>
Co-authored-by: Andrew Gene Brown <[email protected]>
Co-authored-by: Andrew Gene Brown <[email protected]>
|
Thanks @brownag for those suggestions! I've got a couple of tiny tweaks, and then ready to merge. |
|
We can do a final vote on the default axis style just before CRAN release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experimenting with a more modern depth axis for
plotSPC()along with more options for customization. Changes will include new arguments and removal / deprecation of previous arguments. This could break some old code. Thinking about ways to ease the transition.plot.depth.axisn.depth.tickscex.depth.axisTODO:
depth.axisintervalargumentReorganized NEWs and added commentary to "sketches" tutorial.
Also fixing #290.