Add Lidar tutorial by @mazingaro #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veroandreo
commented
Oct 6, 2024
| "\n", | ||
| "This tutorial can be run locally. You need to have GRASS GIS 8.4+ and Jupyter installed. The processes demands some specific libraries. Be sure to have numpy, pandas, geopandas, pdal, python-pdal and tiledbb with pybabylonjs. \n", | ||
| "\n", | ||
| "The first thing we need to do for any of the cases we'll see further on, is to import GRASS GIS python packages. In order to do so, we need to add GRASS GIS python package to PATH. Let's see how we do that." |
There was a problem hiding this comment.
maybe this can be moved below, where this is actually happening?
Comment on lines
+190
to
+208
| { | ||
| "cell_type": "code", | ||
| "execution_count": null, | ||
| "id": "f67c8b8f", | ||
| "metadata": {}, | ||
| "outputs": [], | ||
| "source": [ | ||
| "# Let's check the environment settings: with os.environ[] we can see all of them\n", | ||
| "os.environ['GRASS_OVERWRITE'] # This environent variable shows us if we can overwrite our outputs. " | ||
| ] | ||
| }, | ||
| { | ||
| "cell_type": "markdown", | ||
| "id": "71e59b8d", | ||
| "metadata": {}, | ||
| "source": [ | ||
| "- Question: What can wee see from the output above? Is it the same as we are used in GRASS?" | ||
| ] | ||
| }, |
There was a problem hiding this comment.
I am not sure about this, maybe not needed?
There was a problem hiding this comment.
The whole part about the GRASS_OVERWRITE? I think that is really useful for GRASS users to know, that now they have to be careful here, as overwriting is set by default.
| "id": "4ccb7f8b", | ||
| "metadata": {}, | ||
| "source": [ | ||
| "Is that composite better or worse than an interpolated, raw one for your future data analysis?" |
There was a problem hiding this comment.
consider adding some explanation
Comment on lines
+766
to
+767
| "# We can see differences on microtopography:\n", | ||
| "# Let's denoise and see how does local noise affect the elevation mode\n", |
There was a problem hiding this comment.
Suggested change
| "# We can see differences on microtopography:\n", | |
| "# Let's denoise and see how does local noise affect the elevation mode\n", | |
| "# We can see differences on microtopography:\n", | |
| "# Let's denoise and see how does local noise affect the elevation model\n", |
There was a problem hiding this comment.
Again, this requires guidance/explanations
| "id": "fd959956", | ||
| "metadata": {}, | ||
| "source": [ | ||
| "Create a temporary directory or if you created one in the beginning just use that." |
There was a problem hiding this comment.
Please explain why you do these steps, and maybe better just use here the same temp directory you created to avoid confusion, i.e., keep it simple
Co-authored-by: Veronica Andreo <[email protected]>
Co-authored-by: Veronica Andreo <[email protected]>
Co-authored-by: Veronica Andreo <[email protected]>
Co-authored-by: Veronica Andreo <[email protected]>
Co-authored-by: Veronica Andreo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's currently in .ipynb format, so it'll require conversion to .qmd and formatting fixes. It also requires a link to the data so it can be fully reproduced.