Skip to content

Commit

Permalink
Drop ndk-glue dependency from the main crate
Browse files Browse the repository at this point in the history
Commit d42d201 ("Update Android dependencies and example.") correctly
replaces `ndk-glue` with `ndk-context` as a more generic crate to hold on
to a global `JavaVM` and Android `jobject` `Context`, but didn't drop the
unused `ndk-glue` crate from the list of Android dependencies.  This
crate is only used in the example crate, and [shouldn't clobber
downstream crates].

Besides, `ndk-glue` has been deprecated for some time and should be
replaced by `android-activity` in the example in a followup PR.

[shouldn't clobber downstream crates]: https://github.com/emilk/egui/pull/3606/files#r1401313794
  • Loading branch information
MarijnS95 committed Nov 21, 2023
1 parent 5c528f1 commit 2a81dc9
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@ web-sys = { version = "0.3", features = [
[target.'cfg(target_os="android")'.dependencies]
jni = "0.21"
ndk-context = "0.1"
ndk-glue = "0.7"

[package.metadata.docs.rs]
no-default-features = true
Expand Down

0 comments on commit 2a81dc9

Please sign in to comment.