Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a option to use the OS native share modal. #29

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DhrRob
Copy link

@DhrRob DhrRob commented Apr 5, 2024

Add a native share modal navigator.share().
Would probably have to add some check (e.g. is_ssl()) to check if HTTPS is being used, as that's a requirement for the Navigator.share().

In reference to:

  1. Include default share sheet button #19
  2. add web share api button #24

My first ever PR, hope this is alright!

@DhrRob
Copy link
Author

DhrRob commented Apr 5, 2024

Tried creating a new social-sharing-block.pot but ran into errors sadly.

 *  Executing task: npm run update-pot 


> [email protected] update-pot
> wp i18n make-pot . languages/social-sharing-block.pot --exclude=src

'wp' is not recognized as an internal or external command,
operable program or batch file.

 *  The terminal process "C:\Program Files\PowerShell\7\pwsh.exe -Command npm run update-pot" terminated with exit code: 1. 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant