Enhance logging, error reporting. #214
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added the onlog callback to the ww. Can be used by whoever is using the ww to ascertain progress, etc. In NDTjs the logger now sends messages to that callback too. - Add onopen,onerror and onclose event handlers to NDTjs. The first two are trivial, but onclose tries to analyze the close event and produce some useful messages, especially in the case of abnormal websocket closure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
using the ww to ascertain progress, etc. In NDTjs the logger now
sends messages to that callback too.
two are trivial, but onclose tries to analyze the close event and
produce some useful messages, especially in the case of abnormal
websocket closure.