Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(API): Add endpoint to get drivers in a session #45

Merged
merged 1 commit into from
Sep 30, 2022

Conversation

ndv99
Copy link
Owner

@ndv99 ndv99 commented Sep 29, 2022

This PR is for API changes

Changes

List the changes you made in this PR.

  • Added an API endpoint to get a list of drivers in a session

QA

API

If there are no errors, you should be able to get a Heroku preview deployment in the message reading "This branch was successfully deployed".

QA Steps

  1. Once the heroku preview deployment is ready, open Postman (or other API testing software), and make a query to /api/sessionDrivers?year=2022&event=Italy&session=1
  2. Ensure that the response contains all drivers who participated in Practice 1 in Italy 2022
  3. Change the year, event, and session a few times and ensure that the correct data is returned.

Example response:

{
    "drivers": [
        {
            "name": "Max Verstappen",
            "abbreviation": "VER"
        },
        {
            "name": "Carlos Sainz",
            "abbreviation": "SAI"
        },
        ...
    ]
}

Related issues

Linked to #4

@ndv99 ndv99 added the enhancement New feature or request label Sep 29, 2022
@ndv99 ndv99 requested a review from aliveSurfin September 29, 2022 15:43
@vercel
Copy link

vercel bot commented Sep 29, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
openf1 ✅ Ready (Inspect) Visit Preview Sep 29, 2022 at 3:43PM (UTC)

@ndv99 ndv99 temporarily deployed to openf1-api-getsessiondr-w8s13x September 29, 2022 15:44 Inactive
@ndv99 ndv99 merged commit 3defc30 into main Sep 30, 2022
@ndv99 ndv99 deleted the api_getSessionDrivers branch September 30, 2022 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants