Astra: add option to act_proposal to not execute the proposal

[amityadav0]

• add no_execute: Option
• add ExecuteProposal Action
• add tests
• documentation

[sczembor]

I think we should add another status Executed since now we have a possibility to have an approved proposal but not executed

[amityadav0]

I don't think Executed is needed. This will create ambiguity around Approved, Rejected or Expired.
We could add a new boolean but I think current implementation makes more sense. we keep the proposal in InProgress state unless it is executed with any result

[amityadav0]

Also we don't have Approved with not executed possibility, If due to some reason proposal is not executed, the state will change to Failed which can be finalised using Finalize action

[sczembor]

Also we don't have Approved with not executed possibility, If due to some reason proposal is not executed, the state will change to Failed which can be finalised using Finalize action

but we have an approved proposal (in terms of votes) but not executed. Since we can decide to execute the proposal once the last vote is submitted or not. That's why I think it would make more sense to create a new status. How a user will now if the proposal has reached the approved status if we change the state only after its executed?

[amityadav0]

I still think this will be Ambiguous to know status of proposal if we put Executed as status.

• About last question, the current logic is like that, if proposal status is changed that means it is executed. so I kept it same and added an extra Execute action.
• IF we still do this, I think having an bool executed is better. true for executed false for not executed
  @robert-zaremba What do you think ?

[robert-zaremba]

few small comments