Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: cargo near new integration test + gh workflow to autorenew image tag/digest #235

Merged
merged 16 commits into from
Oct 28, 2024
Merged

ci: cargo near new integration test + gh workflow to autorenew image tag/digest #235

merged 16 commits into from
Oct 28, 2024

Conversation

dj8yfo
Copy link
Collaborator

@dj8yfo dj8yfo commented Oct 21, 2024 •
edited
Loading

No description provided.

@dj8yfo dj8yfo force-pushed the cargo_near_new_intger_test branch 3 times, most recently from 816b1b8 to f9b7660 Compare October 22, 2024 09:41
@dj8yfo dj8yfo force-pushed the cargo_near_new_intger_test branch 3 times, most recently from a8393e7 to 60be55a Compare October 22, 2024 20:49
@dj8yfo dj8yfo force-pushed the cargo_near_new_intger_test branch 4 times, most recently from 3c60405 to d6fa2f6 Compare October 23, 2024 17:43
dj8yfo
dj8yfo commented Oct 24, 2024
View reviewed changes
.github/workflows/crontab_new_template_renewal.yml
- name: Create Pull Request
uses: peter-evans/create-pull-request@v7
with:
title: update `cargo near new` template `image` and `image_digest`
Copy link
Collaborator Author

@dj8yfo dj8yfo Oct 24, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

example of pr created dj8yfo/gh_self_create_pr#3 ,
it renews previous pr automatically and doesn't create one if there's no change

dj8yfo
dj8yfo commented Oct 25, 2024
View reviewed changes
integration-tests/tests/cargo_near_new.rs
/// differs from [test_cargo_test_on_generated_project] in the aspect, that current test
/// uses [cargo_near_build::build] logic from current *cargo-near* branch, whereas
/// [test_cargo_test_on_generated_project] uses [cargo_near_build::build] logic from
/// latest published [near_workspaces::compile_project]
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this test addresses suggestion in #229 (comment)

@dj8yfo dj8yfo force-pushed the cargo_near_new_intger_test branch 2 times, most recently from 8d74259 to ec5a4df Compare October 25, 2024 13:36
@dj8yfo
Copy link
Collaborator Author

dj8yfo commented Oct 25, 2024

@race-of-sloths include

@race-of-sloths
Copy link

race-of-sloths commented Oct 25, 2024 •
edited
Loading

@dj8yfo Thank you for your contribution! Your pull request is now a part of the Race of Sloths!
King of Sloths shakes your hand! Yellow leader's jersey is yours deservedly!

Shows inviting banner with latest news.

Shows profile picture for the author of the PR

Current status: executed
Reviewer Score
@frol 13

Your contribution is much appreciated with a final score of 13!
You have received 143 (130 base + 10% lifetime bonus) Sloth points for this contribution

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

  • Tag @race-of-sloths inside your pull requests
  • Wait for the maintainer to review and score your pull request
  • Check out your position in the Leaderboard
  • Keep weekly and monthly streaks to reach higher positions
  • Boast your contributions with a dynamic picture of your Profile

For maintainers:

  • Score pull requests that participate in the Race of Sloths
  • Engage contributors with fair scoring and fast responses so they keep their streaks
  • Promote the Race to the point where the Race starts promoting you
  • Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands
  • For contributors
    • Include a PR: @race-of-sloths include to enter the Race with your PR
  • For maintainers:
    • Invite contributor @race-of-sloths invite to invite the contributor to participate in a race or include it, if it's already a runner.
    • Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
    • Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
    • Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

@dj8yfo dj8yfo marked this pull request as ready for review October 25, 2024 14:06
@dj8yfo dj8yfo changed the title ci: cargo near new integration test ci: cargo near new integration test + gh workflow to autorenew image tag/digest Oct 25, 2024
frol
frol approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@frol frol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@race-of-sloths score 13

@frol frol merged commit 7657e22 into near:main Oct 28, 2024
17 checks passed
@frol frol mentioned this pull request Oct 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frol frol frol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dj8yfo @race-of-sloths @frol