Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: cover wNEAR with tests #202

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

feat: cover wNEAR with tests #202

wants to merge 9 commits into from

Conversation

itegulov
Copy link

@itegulov itegulov commented Feb 3, 2022

Fixes #197

This PR migrates existing tests to workspaces and add new ones to cover storage functions, ft_transfer_call and wNEAR-specific functions.

I will do another pass tomorrow to make sure I haven't missed anything.

@itegulov itegulov marked this pull request as ready for review February 4, 2022 02:03
austinabell
austinabell reviewed Feb 4, 2022
View reviewed changes
Copy link
Contributor

@austinabell austinabell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks generally good to me. Will have another scan through tomorrow but still not sure who manages/owns the wNEAR contract to upgrade

w-near/Cargo.toml Outdated Show resolved Hide resolved
w-near/test-w-near-defi/src/lib.rs Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@austinabell austinabell austinabell left review comments

@jberrytech jberrytech Awaiting requested review from jberrytech jberrytech is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

wNEAR: lack of test coverage
2 participants
@itegulov @austinabell