Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(multisig-factory): Resolve bug where child account isn't receiving deposit #236

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

denbite
Copy link

@denbite denbite commented Oct 23, 2024

Upgraded near-sdk to 5.3.0 as the old version 2.0.0 caused a bug where env::attached_deposit() call always returned zero

Leading to LackBalanceFormState error on the child account
image


Example of Transaction BEFORE The Fix
https://testnet.nearblocks.io/txns/3hAThdBV5sk9DurAdJKJe5igYLv6myAMK4zGNj6ankA9

Example of Transaction AFTER The Fix
https://testnet.nearblocks.io/txns/3sgM3RY2PeCKSB3umGc1cbnYSwsgnrNzx5dGXcxsrsFL

Copy link
Contributor

@frol frol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, I have a small suggestion and once that is addressed, we can merge it

@race-of-sloths invite

multisig-factory/src/lib.rs Outdated Show resolved Hide resolved
@race-of-sloths
Copy link

🙁 This repository is not a part of the Race of Sloths

Please ask the maintainer to contact us to join the race!

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

  • Tag us inside your pull requests
  • Wait for the maintainer to review and score your pull request
  • Check out your position in the Leaderboard
  • Keep weekly and monthly streaks to reach higher positions
  • Boast your contributions with a dynamic picture of your Profile

For maintainers:

  • Score pull requests that participate in the Race of Sloths
  • Engage contributors with fair scoring and fast responses so they keep their streaks
  • Promote the Race to the point where the Race starts promoting you
  • Grow the community of your contributors

Feel free to check our website for additional details!

@denbite
Copy link
Author

denbite commented Oct 23, 2024

@frol good advice, thank you

@denbite
Copy link
Author

denbite commented Oct 24, 2024

Proof that bringing GasWeight(1) didn't break anything
https://testnet.nearblocks.io/txns/A5k6TM8rYDpTWmKUpCAqLGSXYLKPNThmUskspnniWyv2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants