docker builder for building contracts #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We need also pin to a specific stable rust version to produce deterministic wasm output. We now pin rust-toolchain to nearcore's rust-toolchain, but that's a nightly and for use near-runtime-standalone in tests. Does latest (1.44.1) sounds good? |
willemneal
changed the title
|
@olonho a working contract builder image, might be helpful to you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#40 Also update all wasm to be built by this docker. By building on docker I found it's conflicting of rust-toolchain file and cargo +stable (error: stable is not installed). Since we want pinned toolchain, I think we should all stick with version in rust-toolchain file.