Set up Sentry #103
Merged
Set up Sentry #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Currently it seems the lint job is failing. Also can we confirm that sentry and |
esaminu
reviewed
Nov 2, 2023
| @@ -42,6 +43,7 @@ class FirestoreController { | |||
| .then((res) => res.json()) | |||
There was a problem hiding this comment.
I think it's a good idea to capture an exception with the publicKey and email / firebase user id when {indexer}/accounts returns an empty array here and other relevant places we call it wdyt?
esaminu
reviewed
Nov 2, 2023
src/index.tsx
Outdated
Comment on lines
34
to
38
| 'https://mpc-recovery-leader-mainnet-tmp-cg7nolnlpa-ue.a.run.app', | ||
| 'https://api.kitwallet.app', | ||
| // TESTNET | ||
| 'https://mpc-recovery-leader-dev-7tk2cmmtcq-ue.a.run.app', | ||
| 'https://testnet-api.kitwallet.app' |
There was a problem hiding this comment.
Nice but should we get these from env?
esaminu
reviewed
Nov 2, 2023
webpack.config.js
Outdated
| FIREBASE_MEASUREMENT_ID_TESTNET: 'G-HF2NBGE60S' | ||
| }) | ||
| ], | ||
| plugins: [new HtmlWebpackPlugin({ |
There was a problem hiding this comment.
Can this be prettified slightly similar to before the change?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains initial implementation of Sentry, FE error monitoring tool.
During the implementation, I have created manual throw error on this test scenario to make sure errors are being reported back to sentry.
Things have been tested:
Things have not been handled:
Since this PR contains implementation to upload sourcemap to sentry, we need to update github actions to add
SENTRY_AUTH_TOKENto pipeline. This needs to be done before we merge this PR. Please contact me for retrieval of actual token.Lastly, current setup is currently implemented via sentry account of my own. In the future, we can easily swapped into Pagoda sentry account.