E2e test for sign-multichain #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
benmalcom
force-pushed
the
test/sign-multichain
branch
from
2f3c270
to
4ec827b
Compare
benmalcom
force-pushed
the
test/sign-multichain
branch
from
4ec827b
to
c1f5cb8
Compare
benmalcom
force-pushed
the
test/sign-multichain
branch
from
a69544f
to
8ee1a5f
Compare
benmalcom
force-pushed
the
test/sign-multichain
branch
from
369682c
to
643839d
Compare
Send secrets to process.env Send .env to playwright config
benmalcom
force-pushed
the
test/sign-multichain
branch
from
9e33033
to
6c9d844
Compare
hcho112
reviewed
Jun 23, 2024
.github/workflows/playwright.yml
Outdated
| run: | | ||
| echo "ETH_PROVIDER_URL_TESTNET=${{ secrets.ETH_PROVIDER_URL_TESTNET }}" >> $GITHUB_ENV | ||
| echo "BNB_PROVIDER_URL_TESTNET=${{ secrets.BNB_PROVIDER_URL_TESTNET }}" >> $GITHUB_ENV | ||
| echo "BTC_PROVIDER_URL_TESTNET=${{ secrets.BTC_PROVIDER_URL_TESTNET }}" >> $GITHUB_ENV |
There was a problem hiding this comment.
why does it have to be passed down to .env instead of directly feed into process.env like
MULTICHAIN_TEST_ACCOUNT_ID: ${{ secrets.MULTICHAIN_TEST_ACCOUNT_ID }}
There was a problem hiding this comment.
@hcho112 that's right.
Fixed.
hcho112
previously approved these changes
Jun 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the PR for sign-multichain e2e tests