Add evm function call #270

Pessina · 2024-07-19T09:25:42Z

This PR includes:

Add support for EVM Function Call using ChainSignatures
Add local EVM blockchain using hardhat for testing purpose
Fix Webkit bug on Submit button

Obs: The tests for this PR are expected to be flaky as they depend on relayer and ChainSignature contract that fail frequently. The solution would be run those dependencies locally (I can setup this later)

…ta function

hcho112 · 2024-07-30T01:51:18Z

packages/near-fast-auth-signer-e2e-tests/contracts/FT.sol

@@ -0,0 +1,92 @@
+// Origal repo: https://github.com/Consensys/Tokens/blob/master/contracts/eip20/EIP20.sol


so this file is extended version of file from above link? could you add a bit more detail about what has modified/extended and why? (eg. I notice that mint doesn't exist on above, but added below)

I didn't added any explanation because we will never change this file again. It's just a contract implementing the ERC20 interface for testing.

The code here was copy pasted from the URL linked, and the mint function was added so we can distribute the tokens as we want for testing.

I was checking other options to implement this contracts, looks like Open Zeppelin haves a npm package with the implementations for all we need ERC20, ERC721, ERC1155.

But if it's ok I would like to tackle this in another PR, there is too much work here already.

That's the package I'm looking to use: https://www.npmjs.com/package/@openzeppelin/contracts

hcho112 · 2024-07-30T01:58:50Z

packages/near-fast-auth-signer/src/components/SignMultichain/SignMultichain.tsx

-      const isUserAuthenticated = await getAuthState();
-      if (isUserAuthenticated !== true) {
-        onError('You are not authenticated or there has been an indexer failure');
-      } else {


is it ok to exclude isUserAuthenticated check?

I moved it to here:

fast-auth-signer/packages/near-fast-auth-signer/src/components/SignMultichain/SignMultichain.tsx

Line 130 in db52750

const isUserAuthenticated = await getAuthState();

We need to be authenticated before estimate the gas for the function call.

hcho112

This is amazing work. Left few comments. Would prefer to get more reviews from rest of the team

race-of-sloths · 2024-08-14T07:26:13Z

❌ PR inactive

This PR has been inactive for two weeks. It's now marked as stale.

Tip

If you think it's a mistake, you can restart the bot with include command to proceed 🔄

packages/near-fast-auth-signer/src/components/SignMultichain/bitcoin/schema.ts

esaminu · 2024-08-26T22:14:16Z

packages/near-fast-auth-signer/src/components/SignMultichain/evm/schema.ts

-  maxFeePerGas:         yup.mixed<bigint>().optional(),
-  maxPriorityFeePerGas: yup.mixed<bigint>().optional(),
-  gasLimit:             yup.mixed<bigint>().optional(),
+export const SendEVMMultichainMessageSchema = BaseSendMultichainMessageSchema.shape({


We should also validate the chainId like before. Also are we no longer supporting dapps specifying the gas themselves and only fetching when it's not specified?

The chainId it's being validate on the derivationPath.

For the other properties, the type mixed accepts anything, but you are right we should narrow the validation. I will improve it

What about EVM chain previously validated here:

chainId: yup.lazy((value) => yup.mixed<bigint>().test( 'is-valid-chainId', `Invalid chainId value: ${value}`, (val) => [BigInt(1), BigInt(56), BigInt(97),

esaminu · 2024-08-26T22:19:28Z

packages/near-fast-auth-signer/src/components/SignMultichain/bitcoin/schema.ts

-  // Check if both are present or both are undefined
-  if ((fee && utxos) || (!fee && !utxos)) {
-    return true; // Validation succeeds
+  transaction: yup.object().shape({


We should validate that a from is provided here. As discussed the dapp can choose to be explicit about the from and if it is provided the signer should check that it matches the derivation path

The BTC doesn't accept a from, even if provided it will be ignored, now and before.

The EVM can accept a from and as discussed it will be validated on the multichain-tools, here is the place where the validation occurs: https://github.com/near/multichain-tools/blob/cce661c13a53b8b89dde5f3c82f3aadd1790a0aa/src/chains/EVM/EVM.ts#L156

esaminu · 2024-08-26T22:20:16Z

packages/near-fast-auth-signer/src/components/SignMultichain/evm/schema.ts

-  maxPriorityFeePerGas: yup.mixed<bigint>().optional(),
-  gasLimit:             yup.mixed<bigint>().optional(),
+export const SendEVMMultichainMessageSchema = BaseSendMultichainMessageSchema.shape({
+  transaction:    yup.mixed().required(),


Since it's no longer validated in the base schema, we should make sure that the dev has passed in a to, value and optionally a from here

Good point, it will be fixed when we narrow down the schema

esaminu

LGTM. Great work @Pessina !

Pessina added 30 commits June 25, 2024 17:29

Refactor to match new multichain tools interface

ba687de

Fix typescript errors

682c50a

Improve fast-auth-wallet types

b288cea

Roll back yarn lock

2188e43

Fix imports

4a94035

Fix validation

6a29c94

Fix BNB fee and simplify logic to get Asset Metadata

c107a34

Use SendMultiChainMessage instead of ChainDetails on get asset metada…

b344e63

…ta function

Add sync comment on SignMultichainMessage type

6b32fb7

Remove unused packages

f2cf1a9

Add wallet on beta version and fix types

39751d7

Fix multichain tests

5ad56a0

Update sign transaction with new wallet interface

3f7e44a

Add test for FunctionCall

18c41e3

Remove unused variable

c085798

Remove only from MultiChain test

a68dfa2

Add new packages

72fdd84

Add EVM FunctionCall to iFrame interface

9c7261b

Remove unused methods and make callContractWithDataField more flexible

a9c2529

Include all derived addresses for johndoe12.testnet

6296b72

Add tests for EVM FunctionCall

09870c7

Re-use constant derive address on faucets

f17be10

Clean up code

0a0ed58

Skip EVM function call tests as it will hit the Infura limit

459a495

Remove unused code

07c99b7

Fix overflow and rename constant

322e667

Include from on EVM fee estimation transaction

0acdc02

Deployment with ethers on local hardhat network working

93445c8

Add hardhat to e2e workspace and deploy contract from testset

f36d717

Add CHAIN_CONFIG to getMultichainAssetInfo

8cdafa2

Update to use contract v5

c75ff41

vercel bot deployed to Preview July 24, 2024 16:32 View deployment

Update Unknown key address

787f615

vercel bot deployed to Preview July 24, 2024 17:13 View deployment

Add correct EVM_DOMAIN key

40b302a

vercel bot deployed to Preview July 24, 2024 17:16 View deployment

Merge remote-tracking branch 'origin/main' into add-evm-function-call

f8416eb

vercel bot deployed to Preview July 25, 2024 10:04 View deployment

Update playwright file

db52750

vercel bot deployed to Preview July 25, 2024 12:02 View deployment

hcho112 reviewed Jul 30, 2024

View reviewed changes

Pessina added 3 commits August 25, 2024 14:26

Upgrade versions and fix types

972d21e

Merge remote-tracking branch 'origin/main' into add-evm-function-call

eafbd0d

Upgrade packages and contract

e515578

vercel bot deployed to Preview August 25, 2024 12:07 View deployment

Reduce project to avoid concurrency issues

30c7380

vercel bot deployed to Preview August 25, 2024 15:09 View deployment

esaminu reviewed Aug 26, 2024

View reviewed changes

packages/near-fast-auth-signer/src/components/SignMultichain/bitcoin/schema.ts Outdated Show resolved Hide resolved

esaminu reviewed Aug 26, 2024

View reviewed changes

PR comments

0e0f5f8

vercel bot deployed to Preview August 28, 2024 14:50 View deployment

Add chainId validation

39ea0a5

vercel bot deployed to Preview September 1, 2024 15:38 View deployment

esaminu approved these changes Sep 9, 2024

View reviewed changes

Pessina merged commit df38c9d into main Sep 10, 2024
4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add evm function call #270

Add evm function call #270

Pessina commented Jul 19, 2024 •

edited

Loading

hcho112 Jul 30, 2024

Pessina Jul 30, 2024

hcho112 Jul 30, 2024

Pessina Jul 30, 2024

hcho112 left a comment

race-of-sloths commented Aug 14, 2024

esaminu Aug 26, 2024

Pessina Aug 28, 2024 •

edited

Loading

esaminu Aug 29, 2024

esaminu Aug 26, 2024

Pessina Aug 28, 2024

esaminu Aug 26, 2024

Pessina Aug 28, 2024

esaminu left a comment

		@@ -0,0 +1,92 @@
		// Origal repo: https://github.com/Consensys/Tokens/blob/master/contracts/eip20/EIP20.sol

Add evm function call #270

Add evm function call #270

Conversation

Pessina commented Jul 19, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hcho112 left a comment

Choose a reason for hiding this comment

race-of-sloths commented Aug 14, 2024

❌ PR inactive

Choose a reason for hiding this comment

Pessina Aug 28, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

esaminu left a comment

Choose a reason for hiding this comment

Pessina commented Jul 19, 2024 •

edited

Loading

Pessina Aug 28, 2024 •

edited

Loading