-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: client #1372
feat: client #1372
Conversation
|
ecdaf67
to
e5e4203
Compare
be989a4
to
5f1af5f
Compare
015c916
to
e1e7c2f
Compare
5f1af5f
to
1290913
Compare
096c8d4
to
2fdb57d
Compare
1290913
to
8e0b078
Compare
60721a0
to
7234a4d
Compare
87b28e7
to
2fa73c1
Compare
Pre-flight checklist
pnpm changeset
to create achangeset
JSON document appropriate for this change.Motivation
WIP implementation for new NAJ client library. Example proposed usage compared to current usage:
Current implementation
Potential implementations
Call function
Call functions add a signing component, which requires initialization of an underlying key store. It still relies on the
Account
class, with the represented account being the transaction signer. The method currently takes several parameters that are only applicable in very specific use cases, making it awkward for general use.The proposed implementation exposes a dedicated method with simple arguments. Initialization of the signer is much more clear by way of a simple initialization method which can trivially be extended to accommodate other signers.
Current implementation
Potential implementations
Create account
Current implementation
Potential implementations
Test Plan
Related issues/PRs