feat: simpler approach -> pending events queue

near · Jul 13, 2023 · 0075fc2 · 0075fc2
1 parent e93df49
commit 0075fc2
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 14 deletions.
diff --git a/src/hooks/usePageAnalytics.ts b/src/hooks/usePageAnalytics.ts
@@ -8,16 +8,6 @@ export function usePageAnalytics() {
   const { asPath } = router;
   useEffect(() => {
     const justPath = asPath.split('?')[0];
-    // wait for analytics library to initilize on initial page load before sending event
-    if (window.analyticsInitialized) {
-      recordPageView(justPath);
-    } else {
-      const checkInterval = setInterval(() => {
-        if (window.analyticsInitialized) {
-          recordPageView(justPath);
-          clearInterval(checkInterval);
-        }
-      }, 100);
-    }
+    recordPageView(justPath);
   }, [asPath]);
 }
diff --git a/src/utils/rudder-analytics.ts b/src/utils/rudder-analytics.ts
@@ -10,11 +10,11 @@ let rudderAnalytics: Analytics | null = null;
 let anonymousUserId = '';
 let hashId = '';
 let anonymousUserIdCreatedAt = '';
+let pendingEvents: any = [];
 
 declare global {
   interface Window {
     rudderanalytics: Analytics | undefined;
-    analyticsInitialized: boolean;
   }
 }
 
@@ -63,7 +63,10 @@ export async function init() {
     window.rudderanalytics.load(rudderAnalyticsKey, analyticsUrl);
     rudderAnalytics = window.rudderanalytics;
     if (rudderAnalytics) rudderAnalytics.setAnonymousId(getAnonymousId());
-    window.analyticsInitialized = true;
+    for (const event of pendingEvents) {
+      event();
+    }
+    pendingEvents = []; 
   } catch (e) {
     console.error(e);
   }
@@ -80,7 +83,12 @@ function filterURL(url: string) {
 }
 
 export function recordPageView(pageName: string) {
-  if (!rudderAnalytics) return;
+  if (!rudderAnalytics) {
+    pendingEvents.push(() => {
+      recordPageView(pageName)
+    })
+    return;
+  }
   try {
     rudderAnalytics.page('category', pageName, {
       hashId: localStorage.getItem('hashId'),