Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Private and Signed Out only routes #261

Merged
merged 4 commits into from
Jul 24, 2023
Merged

Private and Signed Out only routes #261

merged 4 commits into from
Jul 24, 2023

Conversation

marcinbodnar
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Jun 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
near-discovery ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 20, 2023 8:19pm
near-discovery-testnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 20, 2023 8:19pm

@marcinbodnar
Copy link
Contributor Author

@mpeterdev it seems like we don't have any private routes now, but I implemented both Private and SignedOut routes, as they are almost identical, and might be useful in the future.

Copy link
Contributor

@shelegdmitriy shelegdmitriy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

src/utils/route/privateRoute.tsx Outdated Show resolved Hide resolved
src/utils/route/signedOutRoute.tsx Outdated Show resolved Hide resolved
@mpeterdev
Copy link
Collaborator

@marcinbodnar can you confirm this is still in a good state to merge?

@marcinbodnar
Copy link
Contributor Author

@mpeterdev it's ready to go.

@charleslavon charleslavon merged commit db6d585 into develop Jul 24, 2023
3 checks passed
@charleslavon charleslavon deleted the feat/DEC-1298 branch July 24, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants