Fix forked component state #358
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
shelegdmitriy
force-pushed
the
fix/forked-component-local-storage
branch
from
1c40cfd
to
cec0e0e
Compare
|
I'm not super familiar with the sandbox editor code, so I'll let @marcinbodnar be the one to approve this one. :) |
There was a problem hiding this comment.
@shelegdmitriy It seems like it doesn't solve the problem, try refreshing the page.
I can take this issue from you, it's a bit problematic, and I think I was fixing the same issue a few months ago.
|
I actually tried and it was working |
|
Have you tried to run my branch locally? |
|
@shelegdmitriy I tried on the preview. |
|
@marcinbodnar I did the same on preview and I can't reproduce this anymore |
shelegdmitriy
force-pushed
the
fix/forked-component-local-storage
branch
from
cec0e0e
to
fa27aac
Compare
shelegdmitriy
force-pushed
the
fix/forked-component-local-storage
branch
from
fa27aac
to
0ac3bd0
Compare
| @@ -440,7 +424,9 @@ export const Sandbox = ({ onboarding = false }) => { | |||
| selectFile(newPath); | |||
| }; | |||
|
|
|||
| // possibly unused | |||
There was a problem hiding this comment.
It seems this section below is unused @marcinbodnar could you confirm that?
shelegdmitriy
force-pushed
the
fix/forked-component-local-storage
branch
from
0ac3bd0
to
59cc867
Compare
shelegdmitriy
force-pushed
the
fix/forked-component-local-storage
branch
from
59cc867
to
4581612
Compare
|
@shelegdmitriy Both preview links seem to work for me. |
There was a problem hiding this comment.
There is an issue with the red dot that indicates if there are any changes made to the component. It doesn't disappear after you undo the changes made.
We can merge it but the issue should be addressed in a separate PR cc @charleslavon
The main issue is resolved and works well.
|
@marcinbodnar good catch! That should be fixed for sure but in a separate PR because it's very minor issue |
* Fix forked component state * Second attemp to fix bug
Closes #348