-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs for MultiChain methods #30
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Pessina this looks good and understandable!
We can also (in the future) export a type intellisense for the fastAuthWallet
instance.
chainId: 11155111n, | ||
}; | ||
|
||
await fastAuthWallet.signAndSendMultiChainTransaction(evmTransactionData); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's currently called signMultiChainTransaction
even though I prefer this naming. I think it's still early enough to change it without a major release? We still have to coordinate with near-multichain-demo though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, as it isn't announced as mainnet, I believe we can introduce breaking changes without a major release. What do you think?
Regarding sync with near-multichain-demo
it's already synced on this PR: near/near-multichain-demo#12
Cool, thanks @benmalcom for the review. Regarding the Intellisense, it comes from the interface defined on the I believe we need a NEP to change this interface. Please correct if I misunderstood your suggestion, or don't see the solution you proposed. I think what you proposed it's a great improvement, but it will come in the future. |
No description provided.