Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: bump sandbox to 1.26.0 #38

Merged
merged 2 commits into from
Jun 3, 2022

Conversation

ChaoticTempest
Copy link
Member

This should address near/near-workspaces-js#170 on the sandbox side. workspaces-js still needs to update to this sandbox version. The workspaces-rs doesn't have to quite yet since it's just overriding to this version anyways

@@ -14,7 +14,7 @@ function getPlatform() {
}
function AWSUrl() {
const [platform, arch] = getPlatform();
return `https://s3-us-west-1.amazonaws.com/build.nearprotocol.com/nearcore/${platform}-${arch}/master/57362268301554563c4f800af963a1270b3d5283/near-sandbox.tar.gz`;
return `https://s3-us-west-1.amazonaws.com/build.nearprotocol.com/nearcore/${platform}-${arch}/master/97c0410de519ecaca369aaee26f0ca5eb9e7de06/near-sandbox.tar.gz`;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I take it there is no tagged version sandbox binary still for mac? Do we have an issue open for this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll create a issue in sandbox, but last time I tested it, it wasn't because of the regex. Apparently it's an oddity of github actions not allowing actions to be triggers on top of other actions. I'll post all my findings there, but it's super strange since it makes the "tag" option seem pointless

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, it's fine to not change rn, just that we should probably create an issue in ops repo to avoid kicking the can down the road indefinitely

@danielwpz
Copy link
Contributor

@austinabell hey, can this be merged and released? currently blocked by this issue :(

@ChaoticTempest ChaoticTempest merged commit a25d272 into main Jun 3, 2022
@ChaoticTempest
Copy link
Member Author

it's released

@ChaoticTempest ChaoticTempest deleted the release/bump-sandbox-to-1.26.0 branch June 12, 2024 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants