fix: fix near-contract-standards event emission #374
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fospring
reviewed
Jan 26, 2024
| @@ -16,17 +16,22 @@ | |||
| import { AccountId } from "near-sdk-js"; | |||
| import { NearEvent } from "../event"; | |||
| import { TokenId } from "./token"; | |||
| import { toSnakeCase } from "../util"; | |||
|
|
|||
| export type Nep171EventKind = NftMint[] | NftTransfer[] | NftBurn[]; | |||
There was a problem hiding this comment.
can you also add the event typf of ContractMetadataUpdate: https://nomicon.io/Standards/Tokens/NonFungibleToken/Event#interface
|
@nujabes403 ci task failed, pls update it if you have time |
|
Hi @nujabes403, I create a MR which contains your commits: #384 |
|
the related MR merged, so I will close this MR |
Great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-flight checklist
Motivation
fungible token, non fungible token contracts in near-contract-standards folder doesn't emit nep141 & nep171 event.
It seems that the code found in the near-contract-standards folder attempts to directly convert near-sdk-rs contracts to TypeScript. However, since it disregards Rust's serde tags and related annotations, there is an issue when emitting events through this contract code, as it doesn't properly track them as nep141 or nep171 events.
Test Plan
Related issues/PRs