[FEAT] NEAR-11: Landing Page Update #3116
Conversation
valmir-haxholli
added
the
New Feature ✨
|
Lets get functionally working first before code review |
|
@hcho112 Thank you for your feedback, I've updated the PR based on your suggestions |
…logic with banner warning
hcho112
force-pushed
the
feature/NEAR-11-landing-page
branch
from
c1d3309
to
5238392
Compare
| import { SetupPassphraseNewAccountWrapper } from '../routes/SetupPassphraseNewAccountWrapper'; | ||
| import { SetupRecoveryImplicitAccountWrapper } from '../routes/SetupRecoveryImplicitAccountWrapper'; | ||
| import { SignWrapper } from '../routes/SignWrapper'; | ||
| // import { CreateImplicitAccountWrapper } from '../routes/CreateImplicitAccountWrapper'; |
There was a problem hiding this comment.
Can we delete these instead of commenting out please?
| <GlobalAlert /> | ||
| { | ||
| {/* { |
There was a problem hiding this comment.
Please delete all commented-out routes so that it is clear exactly which routes remain.
| "landingSectionTitle": "What happened to NEAR Wallet?", | ||
| "landingSectionSubTitle": "Transfer your accounts with ease.", | ||
| "landingSectionSubDescription": "To make the transition easier, you can securely migrate your accounts to a new wallet using the Transfer Wizard. Review the transfer-compatible wallet options below or move your accounts manually with your recovery phrase.", | ||
| "landingSectionDescription": "As we embrace a more decentralized future, the NEAR Wallet will be discontinued.This change invites you to discover a variety of new and secure wallet options within our ecosystem.Don’t worry, no changes will be made to your account or assets.", |
There was a problem hiding this comment.
Needs spaces after periods
| export function PageNotFound() { | ||
| export function PageNotFound({ history }) { | ||
| useEffect(() => { | ||
| recordWalletMigrationEvent('REDIRECT'); |
There was a problem hiding this comment.
Is it worth reporting the requested path here too? If we care enough about 404s from deprecated paths then that also seems relevant.
There was a problem hiding this comment.
Correct!, but I noticed that rudder stack does it internally so decided to not include there:
|
|
||
| const handleOnClickCreateNewAccount = () => { | ||
| if (WEP_DISABLE_ACCOUNT_CREATION) { | ||
| setShowModal('more-near-wallets'); |
There was a problem hiding this comment.
The /create route is gone, should this be the only statement in handleOnClickCreateNewAccount i.e. show the modal with wallets?
Successfully merging this pull request may close these issues:
Replace Landing Page