Workspaces.open() deletion #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's delete
Workspaces.open(), since it's not adding any additional functionality and is pretty confusing. Same result can be achieved by excecutingWorkspaces.init()andworkspace.fork()functions.The only test that was using
open()function is rewritten and moved to the top-level__test__directory. This is the only test that was usingconfigobject, we should add more in the future.Currently, this test is failing, probably because of the #128 issue. It was working fine with
open()function.open()andinit()+fork()are handlingconfigdifferently. I think this is the root cause of the problem. And one more reason to keep one API instead of two.