Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: force ipv4 instead of localhost #200

Merged
merged 4 commits into from
Sep 3, 2024
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/tests-sandbox.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
strategy:
matrix:
platform: [ubuntu-latest, macos-latest]
node-version: [14, 16]
node-version: [14, 16, 18]
gagdiez marked this conversation as resolved.
Show resolved Hide resolved
runs-on: ${{ matrix.platform }}
steps:
- uses: actions/checkout@v2
Expand Down
2 changes: 1 addition & 1 deletion packages/js/dist/server/server.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/js/dist/utils.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions packages/js/dist/worker.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/js/src/server/server.ts
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ export class SandboxServer {
}

get rpcAddr(): string {
return `http://localhost:${this.port}`;
return `http://127.0.0.1:${this.port}`;
}

async start(): Promise<SandboxServer> {
Expand Down
2 changes: 1 addition & 1 deletion packages/js/src/utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ export function urlConfigFromNetwork(network: string | {network: string}): Clien
case 'sandbox':
return {
network: 'sandbox',
rpcAddr: 'http://localhost',
rpcAddr: 'http://127.0.0.1',
};

case 'testnet':
Expand Down
4 changes: 2 additions & 2 deletions packages/js/src/worker.ts
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ export class SandboxWorker extends Worker {
port,
rm: false,
refDir: null,
rpcAddr: `http://localhost:${port}`,
rpcAddr: `http://127.0.0.1:${port}`,
};
}

Expand All @@ -138,6 +138,6 @@ export class SandboxWorker extends Worker {
}

private get rpcAddr(): string {
return `http://localhost:${this.config.port}`;
return `http://127.0.0.1:${this.config.port}`;
}
}