Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix-issue-236: fix TypeError when initialize a Worker in jsdome env… #238

Merged

Conversation

fospring
Copy link
Collaborator

@fospring fospring commented Mar 3, 2024

fix #236

@fospring
Copy link
Collaborator Author

fospring commented Mar 3, 2024

@noble/[email protected] in [email protected] required node engine >=16: https://github.com/paulmillr/noble-hashes/blob/main/package.json#L44

maybe we need to move ci test of node 14

@fospring fospring force-pushed the fix-issue-236/fix-unexpected-type-when-init-worker branch 29 times, most recently from fd649e0 to 4b3f55c Compare March 7, 2024 02:17
@fospring fospring force-pushed the fix-issue-236/fix-unexpected-type-when-init-worker branch 6 times, most recently from 36bd0f5 to 13c5599 Compare March 7, 2024 17:06
…y upgrade dependency and update ci task,remove node14 job
@fospring fospring force-pushed the fix-issue-236/fix-unexpected-type-when-init-worker branch from 13c5599 to 0c65539 Compare March 7, 2024 17:10
@fospring fospring force-pushed the fix-issue-236/fix-unexpected-type-when-init-worker branch from e46e3f7 to ef5e434 Compare March 8, 2024 16:30
Copy link
Member

@ailisp ailisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ailisp ailisp merged commit aed5339 into near:main Mar 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: unexpected type, use Uint8Array
2 participants