Precompiles for BLS12-381 curve operations #9317
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| wasm_bls12381_p1_sum_base: { old: 300_000_000_000_000, new: 15_000_000_000 } | ||
|
There was a problem hiding this comment. Can you give a copy of the raw estimator results as well as how you ran it, to better explain why these numbers are set here to these values? There was a problem hiding this comment. I've updated the PR description as well as the document where I explain how I run it. You can find the results in both the PR description and the document. I rounded up the calculated values. |
||
| wasm_bls12381_p1_sum_element: { old: 300_000_000_000_000, new: 5_500_000_000 } | ||
| wasm_bls12381_p2_sum_base: { old: 300_000_000_000_000, new: 20_000_000_000 } | ||
| wasm_bls12381_p2_sum_element: { old: 300_000_000_000_000, new: 15_000_000_000 } | ||
| wasm_bls12381_g1_multiexp_base: { old: 300_000_000_000_000, new: 15_000_000_000 } | ||
| wasm_bls12381_g1_multiexp_element: { old: 300_000_000_000_000, new: 900_000_000_000 } | ||
| wasm_bls12381_g2_multiexp_base: { old: 300_000_000_000_000, new: 20_000_000_000 } | ||
| wasm_bls12381_g2_multiexp_element: { old: 300_000_000_000_000, new: 1_350_000_000_000 } | ||
| wasm_bls12381_map_fp_to_g1_base: { old: 300_000_000_000_000, new: 1_500_000_000 } | ||
| wasm_bls12381_map_fp_to_g1_element: { old: 300_000_000_000_000, new: 250_000_000_000 } | ||
| wasm_bls12381_map_fp2_to_g2_base: { old: 300_000_000_000_000, new: 1_500_000_000 } | ||
| wasm_bls12381_map_fp2_to_g2_element: { old: 300_000_000_000_000, new: 1_000_000_000_000 } | ||
| wasm_bls12381_pairing_base: { old: 300_000_000_000_000, new: 2_100_000_000_000 } | ||
| wasm_bls12381_pairing_element: { old: 300_000_000_000_000, new: 2_100_000_000_000 } | ||
| wasm_bls12381_p1_decompress_base: { old: 300_000_000_000_000, new: 1_500_000_000 } | ||
| wasm_bls12381_p1_decompress_element: { old: 300_000_000_000_000, new: 90_000_000_000 } | ||
| wasm_bls12381_p2_decompress_base: { old: 300_000_000_000_000, new: 1_500_000_000 } | ||
| wasm_bls12381_p2_decompress_element: { old: 300_000_000_000_000, new: 150_000_000_000 } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’m not sure I understand, why do we need both
ark-bls12-381andblst? Can one of the two not handle the whole feature set? Their documentation’s description seems to be pretty similar.EDIT: AFAIU ark is used only as a second implementation to comparatively fuzz against blst. So this should be fine, feel free to ignore if my understanding at the end of the code review is the correct one :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that's correct, the second library is used only for tests as an alternative implementation.