Skip to content

Commit

Permalink
Prepare for PR
Browse files Browse the repository at this point in the history
  • Loading branch information
darunrs committed Jan 3, 2024
1 parent 23c1416 commit 0b6d68c
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 18 deletions.
1 change: 1 addition & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
# TODO: Move this to New Coordinator's CI Workflow
- name: Install Protoc
uses: arduino/setup-protoc@v2
- name: Run check
Expand Down
2 changes: 1 addition & 1 deletion docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ services:
PORT: 9180
AWS_ACCESS_KEY_ID:
AWS_SECRET_ACCESS_KEY:
RUNNER_HOST: runner
RUNNER_HOST: localhost
RUNNER_PORT: 6001

redis:
Expand Down
15 changes: 0 additions & 15 deletions runner/src/server/runner-client.ts

This file was deleted.

4 changes: 2 additions & 2 deletions runner/src/server/runner-server.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@ export default function startRunnerServer (): grpc.Server {
const server = new grpc.Server();
server.addService(runnerProto.runner.Runner.service, getRunnerService(StreamHandler));
const credentials = grpc.ServerCredentials;
const serverIp = (process.env.RUNNER_HOST ?? 'undefined') + ':' + (process.env.RUNNER_PORT ?? 'undefined');
const serverIpAddress = `${(process.env.RUNNER_HOST ?? 'undefined')}:${(process.env.RUNNER_PORT ?? 'undefined')}`;

server.bindAsync(
serverIp,
serverIpAddress,
credentials.createInsecure(), // TODO: Use secure credentials with allow for Coordinator
(err: Error | null, port: number) => {
if (err) {
Expand Down

0 comments on commit 0b6d68c

Please sign in to comment.