fix: Avoid writing misleading failed/skipped duration metrics (#187)

near · Aug 29, 2023 · 2e64d52 · 2e64d52
1 parent 67164c4
commit 2e64d52
Showing 1 changed file with 4 additions and 6 deletions.
diff --git a/runner/src/index.ts b/runner/src/index.ts
@@ -15,13 +15,11 @@ const processStream = async (streamKey: string): Promise<void> => {
   console.log('Started processing stream: ', streamKey);
 
   let indexerName = '';
-  let startTime = 0;
-  let streamType = '';
 
   while (true) {
     try {
-      startTime = performance.now();
-      streamType = redisClient.getStreamType(streamKey);
+      const startTime = performance.now();
+      const streamType = redisClient.getStreamType(streamKey);
 
       const messages = await redisClient.getNextStreamMessage(streamKey);
       const indexerConfig = await redisClient.getStreamStorage(streamKey);
@@ -50,13 +48,13 @@ const processStream = async (streamKey: string): Promise<void> => {
       await redisClient.deleteStreamMessage(streamKey, id);
 
       const unprocessedMessages = await redisClient.getUnprocessedStreamMessages(streamKey);
+
       metrics.UNPROCESSED_STREAM_MESSAGES.labels({ indexer: indexerName, type: streamType }).set(unprocessedMessages?.length ?? 0);
+      metrics.EXECUTION_DURATION.labels({ indexer: indexerName, type: streamType }).set(performance.now() - startTime);
 
       console.log(`Success: ${indexerName}`);
     } catch (err) {
       console.log(`Failed: ${indexerName}`, err);
-    } finally {
-      metrics.EXECUTION_DURATION.labels({ indexer: indexerName, type: streamType }).set(performance.now() - startTime);
     }
   }
 };