Skip to content

Commit

Permalink
feat: Count S3 get requests made by near-lake-framework (#662)
Browse files Browse the repository at this point in the history
Depends on near/near-lake-framework-rs#102


This PR exposes a new metrics which counts the number of Get requests
made to S3 by `near-lake-framework`. I wanted to start tracking this
metric _before_ I merge the change which reduces them, so I can measure
the impact of that change. The easiest way to track these requests was
to pass a custom `S3Client` to `near-lake-framework`, so we can hook in
to the actual requests made.

The custom `S3Client` (`LakeS3Client`) is exactly the same as the
default implementation in `near-lake-framework` itself, but with the
added metric. This is essentially part 1 for #419, as the "reduction" in
requests will build on this custom client, adding
caching/de-duplication.
  • Loading branch information
morgsmccauley committed Apr 17, 2024
1 parent e23d4c1 commit 733c3c6
Show file tree
Hide file tree
Showing 10 changed files with 1,625 additions and 557 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/block-streamer-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ jobs:
- name: Install Rust
uses: actions-rs/toolchain@v1
with:
toolchain: 1.70.0
toolchain: 1.75.0
override: true
profile: minimal
components: rustfmt
Expand All @@ -71,7 +71,7 @@ jobs:
- name: Install Rust
uses: actions-rs/toolchain@v1
with:
toolchain: 1.70.0
toolchain: 1.75.0
override: true
profile: minimal
components: clippy
Expand Down
Loading

0 comments on commit 733c3c6

Please sign in to comment.