Replace block wait metric with Histogram

near · Nov 21, 2023 · f09a9bb · f09a9bb
1 parent 517616a
commit f09a9bb
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/runner/src/metrics.ts b/runner/src/metrics.ts
@@ -1,10 +1,11 @@
 import express from 'express';
 import { Gauge, Histogram, Counter, AggregatorRegistry } from 'prom-client';
 
-const BLOCK_WAIT_DURATION = new Gauge({
+const BLOCK_WAIT_DURATION = new Histogram({
   name: 'queryapi_runner_block_wait_duration_milliseconds',
   help: 'Time an indexer function waited for a block before processing',
   labelNames: ['indexer', 'type'],
+  buckets: [1, 10, 100, 300, 500, 1000, 3000, 5000, 10000, 30000],
 });
 
 const CACHE_HIT = new Counter({

diff --git a/runner/src/stream-handler/worker.ts b/runner/src/stream-handler/worker.ts
@@ -113,7 +113,7 @@ async function blockQueueConsumer (workerContext: WorkerContext, streamKey: stri
         console.error('Block failed to process or does not have block height', block);
         continue;
       }
-      METRICS.BLOCK_WAIT_DURATION.labels({ indexer: indexerName, type: workerContext.streamType }).set(performance.now() - blockStartTime);
+      METRICS.BLOCK_WAIT_DURATION.labels({ indexer: indexerName, type: workerContext.streamType }).observe(performance.now() - blockStartTime);
       await indexer.runFunctions(block, functions, isHistorical, { provision: true });
 
       await workerContext.redisClient.deleteStreamMessage(streamKey, streamMessageId);