type generation for launchpad code #1001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darunrs
reviewed
Aug 9, 2024
| @@ -45,6 +53,30 @@ const fetchWizardData = (req: string): Promise<WizardResponse> => { | |||
| return request<WizardResponse>('launchpad-create-indexer', req); | |||
| }; | |||
|
|
|||
| const generateCode = async (contractFilter: string, selectedMethods: Method[], selectedEvents?: Event[]) => { | |||
There was a problem hiding this comment.
The function name "generateCode" has been reused multiple times and each time it does something different. Can you rename all of these instances to be more specific? No two functions should ever be the same unless they're in entirely different projects or attached to some class.
There was a problem hiding this comment.
They are all one function and reference. we have a api endpoint that includes generate code and a function that is called generate code that consumes the endpoint.
darunrs
approved these changes
Aug 9, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
types are now generated for launchpad code