Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DPLT-1044 Expose fetch to VM runner #131

Merged
merged 1 commit into from
Jul 16, 2023
Merged

Conversation

morgsmccauley
Copy link
Collaborator

@morgsmccauley morgsmccauley commented Jul 16, 2023

Now that we have the ability to write custom metrics from within the runner, we can start writing the 'lag behind social'. But to do that we need to fetch the latest post block height from api.social.near. For that we need access fetch.

@morgsmccauley morgsmccauley requested a review from a team as a code owner July 16, 2023 21:35
@morgsmccauley morgsmccauley merged commit b2eb980 into main Jul 16, 2023
@morgsmccauley morgsmccauley deleted the DPLT-1044-expose-fetch branch July 16, 2023 21:37
@gabehamilton
Copy link
Collaborator

Can we wrap this in a context method? Adding fetch gives developers lots of functionality (webhook). That is functionality we want to provide but likely will want to wrap in various ways over time: allowlist domains perhaps, check for SSRF attacks.

With webhooks, instead of Indexers developers can build Reactors. We may want to run these differently or provide different options. That starts with knowing which animal we're dealing with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants