DPLT-1076 create node worker to process real time streams #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morgsmccauley
force-pushed
the
DPLT-1076-create-node-worker-to-process-real-time-streams
branch
3 times, most recently
from
1e4313d
to
fcb0bcd
Compare
morgsmccauley
force-pushed
the
DPLT-1076-create-node-worker-to-process-real-time-streams
branch
from
79cfae0
to
aeaeaef
Compare
morgsmccauley
commented
Aug 2, 2023
| storage::sadd( | ||
| context.redis_connection_manager, | ||
| storage::INDEXER_SET_KEY, | ||
| indexer_function.get_full_name(), |
There was a problem hiding this comment.
Storing the indexer name alone to make it easier to build the many other keys related to this indexer, i.e. :storage and :stream
morgsmccauley
commented
Aug 2, 2023
|
|
||
| const results = await client.xRead( | ||
| { key: generateStreamKey(indexerName), id }, | ||
| // can't use blocking calls as running single threaded |
There was a problem hiding this comment.
This might not be true, I'll investigate more later
|
Merging as I'd like to test the related infra. Feel free to comment retrospectively. |
morgsmccauley
deleted the
DPLT-1076-create-node-worker-to-process-real-time-streams
branch
|
Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates a Node app for processing the real-time Redis streams.
I've created a new top-level directory called
runner/to house this code. It borrows most of the code fromindexer-js-queue-handler, but I have:I've added separate commits for copying the file over, and adding the above modifications if you are interested/concerned about the changes. The core logic is in
runner/src/index.ts, most other code has remained the same aside from the above.To process each stream,
runnerwill continuously poll theindexersset to get the list of current indexers, and spin out a promise which polls its respective stream. As Node is single-threaded, this code isn't truely concurrent, and all JS execution will be executed sequentially. However, I/O will be offloaded to the system allowing for some concurrency, and hopefully a system which is still somewhat performant. I'll address concurrency in future PRs.