fix: Local development & add steps in README.md
#173
Conversation
morgsmccauley
force-pushed
the
fix/local-development
branch
from
059ffbc
to
6ffe76d
Compare
morgsmccauley
force-pushed
the
fix/local-development
branch
from
9db6969
to
4d56b88
Compare
morgsmccauley
changed the title
README.md
| WORKDIR /tmp/ | ||
| COPY Cargo.toml Cargo.lock ./ |
There was a problem hiding this comment.
This step caches built dependencies in a docker layer, causing a slower first time build, but faster subsequent builds. We aren't caching docker images in CI, and dev builds don't take too long so this doesn't provide much benefit.
| @@ -1,30 +1,16 @@ | |||
| FROM rust:1.68 AS build | |||
|
|
|||
| ARG CARGO_BUILD_MODE=release | |||
There was a problem hiding this comment.
Default to release builds, but set to debug when building via the local Docker Compose
| @@ -74,13 +74,17 @@ const getMessagesFromStream = async <Message extends Record<string, string>>( | |||
| return results?.[0].messages as StreamMessages<Message>; | |||
| }; | |||
|
|
|||
| const incrementStreamId = (id: string): string => { | |||
There was a problem hiding this comment.
When lastProcessedId was null, this code would generate an invalid ID, causing errors in Redis.
|
It might also be good to highlight steps for running provisioning to get the databases set up too. |
@darunrs that's no longer required, the indexers will self provision. |
This PR contains various fixes to the local development environment, I've commented inline the reasoning for these changes. On top of this, I've expanded
README.mdto include steps for setting up.