Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fetch cargo packages from registry in Docker build #174

Merged
merged 1 commit into from
Aug 9, 2023
Merged

fix: Fetch cargo packages from registry in Docker build #174

merged 1 commit into from
Aug 9, 2023

Conversation

morgsmccauley
Copy link
Collaborator

When we had a multistage build, the second cargo build could use --offline as all packages would exist from the first build. With the first build removed we need to fetch the packages from the registry.

@morgsmccauley morgsmccauley requested a review from a team as a code owner August 9, 2023 20:21
roshaans
roshaans approved these changes Aug 9, 2023
View reviewed changes
Copy link
Contributor

@roshaans roshaans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me now!

@morgsmccauley morgsmccauley merged commit 4172d9a into main Aug 9, 2023
3 checks passed
@morgsmccauley morgsmccauley deleted the fix/docker-build branch August 9, 2023 20:45
@morgsmccauley morgsmccauley mentioned this pull request Apr 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roshaans roshaans roshaans approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@morgsmccauley @roshaans