refactor: Extract registry types in to own crate #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roshaans
reviewed
Dec 14, 2023
| uint = { version = "0.9.3", default-features = false } | ||
| indexer_rule_type = { features = ["nearsdk"], path = "../../indexer/indexer_rule_type" } | ||
| registry-types = { path = "../types", features = ["nearsdk"] } |
There was a problem hiding this comment.
are we using the nearsdk feature?
There was a problem hiding this comment.
Yes - it forces the crate to use near-sdk types so that it is compatible with the registry contract
|
Can we add some details in the main readme about this |
The types are used internally, I'm not sure adding something would provide much benefit? Did you have something specific in mind? |
darunrs
approved these changes
Dec 15, 2023
roshaans
approved these changes
Dec 15, 2023
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extract the types exposed by the registry contract in to its own reusable crate:
registry_types. This was done to avoid the duplication across our different service which; fetch the JSON, and then construct the Rust types.registry_typescrateThe registry types were already partially shared between Coordinator and the registry, but I've expanded on this to include all types rather than just a subset. I've created a new crate, rather than using the existing
./indexer/indexer_rule_typecrate as some packages needed to be upgraded, which caused conflicts across theindexer/cargo workspace - which seemed unnecessary to fix given that it is being deprecated.Registry contract updates
near-sdkversion4.1.1is no longer compilable because it depends on a non-existent crate, hence the upgrade to5.0.0-alpha.1. Since I was already making changes here, I decided to remove the migration related code as it is no longer needed.Consuming
registry_typesWith the shared types in place, I've updated
block-streamer/to use them, removing the existing types which it duplicates. I also went ahead and removed all types which were unused (left over from Alertexer).indexer_rule_typedepends onnear-sdkversion4.1.1(the broken one), and since it's no longer shared, I removed that dependency so that it can compile again.Relates to #421