-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add created/updated at block heights to registry #458
Conversation
7553a2f
to
4ae19e4
Compare
`getrandom` is a dev dependency of `near-sdk` but is actually required
77268d7
to
8a791a7
Compare
@roshaans will these new fields create any problems on the frontend side? I'd expect not because it is an expanding change, rather than removing/updating existing fields? |
The compilation errors originally mentioned in the PR description have now been resolved. These errors were related to the compilation of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Able to build properly! These changes also do not seem like they would affect the frontend in anyway so LGTM 💯
This has been deployed to Dev, I'll let it sit for a couple days and then deploy to Prod if all is ok. |
This PR adds the
created_at_block_height
andupdated_at_block_height
fields toIndexerConfig
within the registry contract. The motive behind this is to provide Coordinator V2 with a way for comparing the actual and desired states of the system, i.e. if there is a mismatch between the registry and the system, action should be taken. Without versions, there is no way of making this comparison.Compilation Errors
I ran in to several issues trying to compile thewasm32
binary, and have outlined all these issues in near/near-sdk-rs#1125, as well as in theREADME.md
so that the fixes are documented. These fixes are a bit janky, but I've tested the deployed contract and all seems to be ok.These have been resolved, see: #458 (comment)
Account Roles Migration
I've also included
account_roles
in this migration as we have some incorrect accounts asOwner
s (pavelnear.near
). All owners will be wiped and re-written from the contract default state. AllUser
s will remain.Coordinator V1
Coordinator V1 has been tested to ensure that it can still parse the registry after these new fields have been applied.