Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prod Release 23/02/24 #580

Merged
merged 2 commits into from
Feb 25, 2024
Merged

Prod Release 23/02/24 #580

merged 2 commits into from
Feb 25, 2024

Conversation

darunrs
Copy link
Collaborator

@darunrs darunrs commented Feb 23, 2024 •
edited
Loading

morgsmccauley and others added 2 commits February 23, 2024 15:18
@morgsmccauley
feat: Add metrics to Block Streamer (#579)
22b582e 
This PR adds the following metrics to Block Streamer:
- `LAST_PROCESSED_BLOCK` - height of last block seen, will be used to
calculate the lag from tip of network
- `PROCESSED_BLOCKS_COUNT` - count of blocks seen, used to calculate BPS
- `PUBLISHED_BLOCKS_COUNT` - count of blocks published to Redis Stream,
to determine whether the block stream is publishing messages
- `LOGS_COUNT` - count logs by level, so we can alert on number of error
logs etc.

I've also slightly refactored `RedisClient` to support this change.
@Kevin101Zhang
Feat: added CORS matching all routes (#578)
7387fdc 
Added a config file. Nextjs will look for a next.config.js file on 'next
dev' and will use the following configurations

Functionality:

Manages HTTP response headers.
Header Configuration:

Allows any origin for all routes.
Specifies allowed methods and headers for CORS.

Result: we should be able to remove any CORS browser extensions that
bypass cross-origin requests that would otherwise be restricted
@darunrs darunrs marked this pull request as ready for review February 23, 2024 20:52
@darunrs darunrs requested a review from a team as a code owner February 23, 2024 20:52
@darunrs
Copy link
Collaborator Author

darunrs commented Feb 23, 2024 •
edited
Loading

We can't quite merge this yet because:

  1. We need to apply changes to prod to scrape block streamer and set METRICS_PORT env var for it too. I suspect Block Streamer would crash without that change.
  2. Terraform apply seems to indicate a replacement of our instances (Including Coordinator V1) due to a COS update, which would restart Coordinator V1. I believe that V1 running briefly is fine, and we can also just shut down the instance immediately too, to be totally sure. Wouldn't mind giving that a go on any day other than Friday.

I'd be happy to briefly work with @morgsmccauley to merge this on his Monday. Shouldn't be too hard. Just don't want to take that nonzero low risk of nonsense happening in deployment before the weekend.

@morgsmccauley
Copy link
Collaborator

@darunrs All sorted, I'll merge this now

@morgsmccauley morgsmccauley merged commit c15cf22 into stable Feb 25, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@darunrs @morgsmccauley @Kevin101Zhang