feat: Cache Streamer Message from Block Streamer #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morgsmccauley
force-pushed
the
feat/cache-streamer-message
branch
from
e894d17
to
9ad1301
Compare
morgsmccauley
commented
Feb 26, 2024
| @@ -20,7 +20,7 @@ export default class RedisClient { | |||
| SMALLEST_STREAM_ID = '0'; | |||
| LARGEST_STREAM_ID = '+'; | |||
| STREAMS_SET_KEY = 'streams'; | |||
| STREAMER_MESSAGE_HASH_KEY_BASE = 'streamer:message:'; | |||
| STREAMER_MESSAGE_HASH_KEY_BASE = 'streamer_message:'; | |||
There was a problem hiding this comment.
: signifies parent, but we don't need that sort of nesting here
morgsmccauley
force-pushed
the
feat/cache-streamer-message
branch
from
9ad1301
to
2679f68
Compare
darunrs
approved these changes
Feb 26, 2024
There was a problem hiding this comment.
LGTM! I think the set command for Redis has never even taken a single ms to complete, so I think we have no problems if all our streamers write on each block.
Only issue is now we're setting a block even during historical (index files done or a * indexer), but a 60sec expiry would prevent that from being a problem, I think. We can loop back to it after observing any changes to memory usage, I think.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.