test: Cancel block_stream task to workaround infinite lake loop #856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darunrs
approved these changes
Jul 9, 2024
| @@ -479,7 +493,7 @@ mod tests { | |||
|
|
|||
| mock_lake_s3_client | |||
| .expect_list_common_prefixes() | |||
| .returning(|_, _| Ok(vec![])); | |||
| .returning(|_, _| Ok(vec![107503704.to_string(), 107503705.to_string()])); | |||
There was a problem hiding this comment.
What caused this to change?
There was a problem hiding this comment.
The test setup wasn't correct, I think they probably got edited while they were ignored
morgsmccauley
force-pushed
the
test/block-stream-fix
branch
from
8321799
to
80a147b
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
near-lake-frameworkwill infinitely retry, making our tests infinitely hang. This PR monitors thelast_processed_ block, and cancels the task from the outside when the last desired block is reached.