refactor(rpc-server): Tweaks and clean up around query.call_function method implementation #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khorolets
force-pushed
the
refactor/query-call-function-tweaks
branch
from
09624a0
to
2f04337
Compare
khorolets
changed the title
kobayurii
requested changes
May 23, 2024
| validators: HashMap<near_primitives::types::AccountId, near_primitives::types::Balance>, | ||
| data_count: u64, | ||
| is_optimistic: bool, | ||
| prefetched_data: |
There was a problem hiding this comment.
This is already deleted in #259. Observations have shown that it is not efficient to request the whole stack. Therefore, this functionality was removed.
| } | ||
|
|
||
| fn get_state_key_data(&self, key: &[u8]) -> readnode_primitives::StateValue { | ||
| if let Some(prefetched_data) = &self.prefetched_data { |
There was a problem hiding this comment.
It is not needed according to the comment above.
|
|
||
| // TODO: Refactor this part. It's a temporary solution to fetch state keys from DB for the poolv1.near contracts | ||
| // https://github.com/near/read-rpc/issues/150 | ||
| let contract_state = if account_id.to_string().ends_with("poolv1.near") { |
There was a problem hiding this comment.
It is not needed according to the comment above.
kobayurii
approved these changes
May 23, 2024
khorolets
force-pushed
the
refactor/query-call-function-tweaks
branch
from
3d45641
to
358814c
Compare
kobayurii
added a commit
that referenced
this pull request
Jun 5, 2024
* fix(near-state-indexer): Fix the TypeError in communication with Redis leading to spam of warnings (#254) * (rpc_server): metrics refactoring and improvements (#255) * merics reffactoring and imrovements * metrics improvements according pr comments * improvement tracing instrument logs (#257) * (database): Implement metrics to count requests for each table (#259) * Implement metrics to count request for each database table * remove logic to fetch all state before contract call * add issue to implement metrics for postgres * rename mentric DATABASE_QUERIES to DATABASE_READ_QUERIES * refactor(rpc-server): Tweaks and clean up around query.call_function method implementation (#258) * refactor(rpc-server): Tweaks and clean up around query.call_function method implementation * Follow the clippy suggestion * Drop redundant pieces of code * fix tx different results (#261) * Metrics(rpc-server): Extend metrics (#263) * extend metrics to collect block category * fmt * code improvement according git comments * Revert "fix tx different results" (#265) This reverts commit 2e4dc30. * feat: added `view_receipt_record` rpc endpoint (#266) * feat: added `view_receipt_record` rpc endpoint * chore: removed leftovers * feat: used appropriate metrics * feat: added proper response structure * docs(view_receipt_record): added new custom method * hook for poolv1.near (#267) * chore: relese v0.2.9 (#268) * proxy next_light_client_block to regular rpc (#269) * fix changelog.md (#270) --------- Co-authored-by: Bohdan Khorolets <[email protected]> Co-authored-by: Ivan Frolov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am thoroughly reviewing the logic around
query.call_functionmethod implementation to find a way to improve the usage of ScyllaDB here. This work is related to the #236While I am here and noticing some areas for improvement, I am also implementing them (Boy Scout Rule in action).
High-level changes
contract_runnerwithin thequeryoneblock_referenceforfetch_block_from_cache_or_getfunction (this actually went a bit beyond thequerymodule tbh)query:: function_call(dropped two similar functions, moved the code to thefunction_callbody, it seems like it belongs there to me)