Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(rpc_server): fix transaction details borsh deserialize #317

Merged
merged 2 commits into from
Aug 2, 2024

Conversation

kobayurii
Copy link
Collaborator

@kobayurii kobayurii commented Aug 2, 2024

Since near/nearcore#10676
the ReceiptEnumView has been changed to include is_promise_yield field
which is not present in the old version of the ReceiptEnumView
by deserializing the old version of the ReceiptEnumView and converting it to the new version

solved: #224

@kobayurii kobayurii changed the title fix transaction details borsh deserialize (rpc_server): fix transaction details borsh deserialize Aug 2, 2024
@kobayurii kobayurii self-assigned this Aug 2, 2024
@kobayurii kobayurii marked this pull request as ready for review August 2, 2024 12:51
@kobayurii
Copy link
Collaborator Author

@race-of-sloths please, include my PR in the Race

@race-of-sloths
Copy link

race-of-sloths commented Aug 2, 2024

@kobayurii Thank you for your contribution! Your pull request is now a part of the Race of Sloths!
Do you want to apply for monthly streak? Get 8+ score for a single PR this month and receive boost for race-of-sloths!

Shows profile picture for the author of the PR

Current status: executed
Reviewer Score
@khorolets 3

Your contribution is much appreciated with a final score of 3!
You have received 40 (30 base + 10 monthly bonus) Sloth points for this contribution

Congratulations @kobayurii! Your PR was highly scored and you completed another monthly streak! To keep your monthly streak make another pull request next month and get 8+ score for it

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

  • Tag @race-of-sloths inside your pull requests
  • Wait for the maintainer to review and score your pull request
  • Check out your position in the Leaderboard
  • Keep weekly and monthly streaks to reach higher positions
  • Boast your contributions with a dynamic picture of your Profile

For maintainers:

  • Score pull requests that participate in the Race of Sloths
  • Engage contributors with fair scoring and fast responses so they keep their streaks
  • Promote the Race to the point where the Race starts promoting you
  • Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands
  • For contributors
    • Include a PR: @race-of-sloths include to enter the Race with your PR
  • For maintainers:
    • Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
    • Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
    • Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

Copy link
Member

@khorolets khorolets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, pretty weird though, but does the job. Thank you!

rpc-server/src/modules/transactions/mod.rs Outdated Show resolved Hide resolved
@kobayurii kobayurii merged commit 9af2748 into database-new Aug 2, 2024
@race-of-sloths
Copy link

🥁 Score it!

@khorolets, please score the PR with @race-of-sloths score [1/2/3/5/8/13]. The contributor deserves it.
If no scoring is provided within 24 hours, this PR will be scored as 1 🦥

@khorolets
Copy link
Member

@race-of-sloths score 3

kobayurii added a commit that referenced this pull request Aug 7, 2024
* fix transaction details borsh deserialize

* clippy
kobayurii added a commit that referenced this pull request Aug 7, 2024
* fix transaction details borsh deserialize

* clippy
kobayurii added a commit that referenced this pull request Aug 7, 2024
* fix transaction details borsh deserialize

* clippy
kobayurii added a commit that referenced this pull request Aug 8, 2024
* fix transaction details borsh deserialize

* clippy
kobayurii added a commit that referenced this pull request Aug 8, 2024
* fix transaction details borsh deserialize

* clippy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants