Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add firebase authentication #49

Merged
merged 3 commits into from
Oct 17, 2023
Merged

feat: add firebase authentication #49

merged 3 commits into from
Oct 17, 2023

Conversation

radomird
Copy link
Contributor

Closes #42

@radomird radomird linked an issue Oct 17, 2023 that may be closed by this pull request
Add firebase authentication #42
Closed
jack-robson
jack-robson suggested changes Oct 17, 2023
View reviewed changes
Copy link

@jack-robson jack-robson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, otherwise LGTM

web/src/components/Header/Header.tsx Outdated Show resolved Hide resolved
jack-robson
jack-robson approved these changes Oct 17, 2023
View reviewed changes
Copy link

@jack-robson jack-robson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@radomird radomird merged commit 6930454 into main Oct 17, 2023
3 checks passed
@radomird radomird deleted the 42-add-firebase-authentication branch October 17, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jack-robson jack-robson jack-robson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add firebase authentication
2 participants
@radomird @jack-robson