Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add test for changing dicts and lists #2724

Merged
merged 2 commits into from
Sep 17, 2024
Merged

add test for changing dicts and lists #2724

merged 2 commits into from
Sep 17, 2024

Conversation

Adam-D-Lewis
Copy link
Member

@Adam-D-Lewis Adam-D-Lewis commented Sep 17, 2024 •
edited
Loading

Reference Issues or PRs

Fixes #2719

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

How to test this PR?

  • Run new tests before fix and see them fail(26a2f2b)
  • Run new tests after fix and see them pass (latest commit)

Any other comments?

Adam-D-Lewis
Adam-D-Lewis commented Sep 17, 2024
View reviewed changes
tests/tests_unit/test_stages.py
@@ -39,7 +39,7 @@ def test_check_immutable_fields_no_changes(mock_get_state, terraform_state_stage
def test_check_immutable_fields_mutable_change(
mock_get_state, terraform_state_stage, mock_config
):
old_config = mock_config.model_copy()
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flyby: test wasn't failing, but wanted to ensure we were deep copying to prevent unintended errors from a shallow copy

Adam-D-Lewis
Adam-D-Lewis commented Sep 17, 2024
View reviewed changes
tests/tests_unit/test_stages.py
@@ -52,7 +52,7 @@ def test_check_immutable_fields_mutable_change(
def test_check_immutable_fields_immutable_change(
mock_model_fields, mock_get_state, terraform_state_stage, mock_config
):
old_config = mock_config.model_copy()
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

viniciusdc
viniciusdc approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@viniciusdc viniciusdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @Adam-D-Lewis

@viniciusdc
Copy link
Contributor

viniciusdc commented Sep 17, 2024 •
edited
Loading

tests are failing due to paramiko, unrelated to your changes

@viniciusdc viniciusdc merged commit a800a5b into develop Sep 17, 2024
27 of 28 checks passed
@viniciusdc viniciusdc deleted the handle_dicts branch September 17, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viniciusdc viniciusdc viniciusdc approved these changes

@marcelovilla marcelovilla Awaiting requested review from marcelovilla

Assignees
No one assigned
Labels
None yet
Projects
🪴 Nebari Project Management
Status: Done 💪🏾
Milestone
Nebari Maintenance Team - September 2024
Development

Successfully merging this pull request may close these issues.

[BUG] - check of immutable fields errors when providing new node_groups
2 participants
@Adam-D-Lewis @viniciusdc