Address issue with AWS instance type schema #2787
Open
+20
−20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues or PRs
closes #2782
What does this implement/fix?
Put a
x
in the boxes that applyTesting
How to test this PR?
As the previous error happened only during
terraform plan
you will need to mock the deployment of nebari, I suggest mofiying the source code to only plan the code instead of deploying (this should work for the second stage, since there are no pre-variable depency AFAIK) -- stage 1 can be skipped by using the state local instead of remote.nebari init aws --project testing-gpu
gpu: enabled
you should seeAL2_X86_64
if gpu is passed, then its variant should show up ``AL2_X86_64_GPU`node_template
block and test if by passing an AMI the intance_type also changes to CUSTOM.Any other comments?
I made a deployment on AWS from this branch and GPUs were working as expected