move disable_target_warnings(fmt)

nebulastream · Sep 30, 2024 · 3c8cd65 · 3c8cd65
1 parent 5e6f8fe
commit 3c8cd65
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/.github/workflows/benchmark.yml b/.github/workflows/benchmark.yml
@@ -28,7 +28,7 @@ jobs:
       - name: cmake
         shell: bash
         run: |
-          cmake -DCMAKE_BUILD_TYPE=Release -D CMAKE_C_COMPILER_LAUNCHER=ccache -D CMAKE_CXX_COMPILER_LAUNCHER=ccache ${{ matrix.flags }}  -G Ninja -S . -B .
+          cmake -DCMAKE_BUILD_TYPE=Release -D CMAKE_C_COMPILER_LAUNCHER=ccache -D CMAKE_CXX_COMPILER_LAUNCHER=ccache -DENABLE_BENCHMARKS=ON ${{ matrix.flags }}  -G Ninja -S . -B .
       - name: build
         shell: bash
         run: |

diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -4,6 +4,7 @@ include(CMakeDependentOption)
 option(ENABLE_LOGGING "Enable logging support" ON)
 option(ENABLE_STACKTRACE "Enable stacktrace support" ON)
 option(ENABLE_TESTS "Enable tests" ON)
+option(ENABLE_BENCHMARKS "Enables tracing and backend benchmarks" OFF)
 option(ENABLE_COMPILER "Enables tracing and backend compilers" ON)
 option(USE_EXTERNAL_FMT "Use a externally provided version of fmt" OFF)
 option(USE_EXTERNAL_SPDLOG "Use a externally provided version of spdlog" OFF)
@@ -61,7 +62,7 @@ if (ENABLE_MLIR_BACKEND AND NOT USE_EXTERNAL_MLIR)
 endif ()
 
 set(EXPORT_TARGETS)
-if (ENABLE_TESTS)
+if (ENABLE_TESTS OR ENABLE_BENCHMARKS)
     set(CATCH_ENABLE_REPRODUCIBLE_BUILD OFF CACHE INTERNAL "Turn off tests")
     add_subdirectory(${THIRD_PARTY_DIR}/Catch2)
     list(APPEND EXPORT_TARGETS Catch2)

diff --git a/nautilus/test/benchmark/CMakeLists.txt b/nautilus/test/benchmark/CMakeLists.txt
@@ -1,4 +1,4 @@
-if (ENABLE_TRACING)
+if (ENABLE_TRACING AND ENABLE_BENCHMARKS)
     add_executable(nautilus-tracing-benchmarks
             TracingBenchmark.cpp
     )